naver / arcus-java-client

ARCUS Java client
Apache License 2.0
50 stars 46 forks source link

INTERNAL: Upgrade JUnit, JMock with test files #793

Closed cheesecrust closed 1 month ago

cheesecrust commented 1 month ago

πŸ”— Related Issue

⌨️ What I did

JUnit μ—…κ·Έλ ˆμ΄λ“œ

JUnit 을 버전 5둜 μ—…κ·Έλ ˆμ΄λ“œ ν•˜λ©΄μ„œ μ½”λ“œμ˜ 변경을 μ΅œμ†Œν™” ν•˜κΈ° μœ„ν•΄ vintage engine 을 μΆ”κ°€ν•˜μ—¬ JUnit 3, 4 의 문법이 ν˜Έν™˜λ˜λ„λ‘ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

JMock μ—…κ·Έλ ˆμ΄λ“œ

JMock1 을 JMock2 둜 μ—…κ·Έλ ˆμ΄λ“œ ν•˜λ©΄μ„œ λͺ‡λͺ‡ 뢀뢄을 μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

κΈ°μ‘΄

clientMock.expects(once()).method("getTranscoder")
            .will(returnValue(transcoder));

λ³€κ²½ ν›„

context.checking(
            new Expectations() {{
              oneOf(client).getTranscoder();
              will(returnValue(transcoder));
            }}
    );
oliviarla commented 1 month ago

@cheesecrust ν˜„μž¬ ν…ŒμŠ€νŠΈ μ½”λ“œμ˜ λ³€κ²½ 사항은 jmock의 μ—…κ·Έλ ˆμ΄λ“œλ‘œ 인해 λ°œμƒν•œ κ²ƒμœΌλ‘œ λ³΄μž…λ‹ˆλ‹€. 이번 PRμ—μ„œλŠ” jmock의 λ²„μ „λ§Œ μ—…κ·Έλ ˆμ΄λ“œν•˜λ„λ‘ ν•˜κ³ , λ‹€μŒ PR둜 junit 버전 μ—…κ·Έλ ˆμ΄λ“œμ™€ κ΄€λ ¨λœ λ‚΄μš©μ„ μ˜¬λ €μ£Όμ„Έμš”.

λ‹€μŒ PRμ—μ„œλŠ” vintage engine μ‚¬μš©ν•˜μ§€ μ•Šκ³  μΈν„°νŽ˜μ΄μŠ€ 변화에 맞좰 λ³€κ²½ν•œ ν›„ junit-jupiter-api, junit-jupiter-engine μ˜μ‘΄μ„±λ§Œ 가지도둝 ν•˜λ©΄ λ©λ‹ˆλ‹€.