naver / arcus-java-client

ARCUS Java client
Apache License 2.0
50 stars 46 forks source link

INTERNAL: Fix transient field #807

Open cheesecrust opened 1 day ago

cheesecrust commented 1 day ago

πŸ”— Related Issue

⌨️ What I did

Warning

non-transient instance field of a serializable class declared with a non-serializable type

μœ„λŠ” 직렬화 κ°€λŠ₯ μ—¬λΆ€κ°€ λͺ…ν™•ν•˜μ§€ μ•Šμ•„ λ°œμƒν•˜λŠ” κ²½κ³  μž…λ‹ˆλ‹€.

CheckedOperationTimeoutException μ—μ„œλŠ” ν•΄λ‹Ή ν•„λ“œλ₯Ό 직렬화가 κ°€λŠ₯ν•œ λͺ…ν™•ν•œ νƒ€μž…μΈ ArrayList 둜 λ³€κ²½ν•˜μ˜€μŠ΅λ‹ˆλ‹€. 이에 λͺ…ν™•ν•œ νƒ€μž…μ— λ§žμΆ”κ³  μ‚¬μš©μžκ°€ μž…λ ₯ν•œ μˆœμ„œλŒ€λ‘œ 메세지λ₯Ό μƒμ„±ν•˜κΈ°μœ„ν•΄ λ‹€λ₯Έ 클래슀의 νƒ€μž… λ˜ν•œ ArrayList 둜 톡일 ν•˜μ˜€μŠ΅λ‹ˆλ‹€. https://github.com/naver/arcus-java-client/pull/807#issuecomment-2362586772

VariousTypeTest μ—μ„œλŠ” 직렬화 κ°€λŠ₯ν•œ λͺ…ν™•ν•œ νƒ€μž…μΈ ArrayList λ₯Ό ν™œμš©ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

oliviarla commented 14 hours ago

@cheesecrust CheckedOperationTimeoutException에 HashSet을 μž…λ ₯ν•˜λŠ” λŒ€μ‹  μ „μ²΄μ μœΌλ‘œ ArrayList νƒ€μž…μ„ μž…λ ₯ν•˜λ„λ‘ λ³€κ²½ν•˜λ©΄ μ–΄λ–¨κΉŒμš”?

Test μ—μ„œλŠ” μˆœμ„œμ— λ§žμΆ”μ–΄ 검증을 ν•˜κ³  μžˆμ–΄ LinkedHashSet 을 ν™œμš©ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

이 뢀뢄을 λ³΄λ‹ˆ μ›λž˜ ArrayListλ₯Ό 넣기도 ν–ˆκ³ , operationsκ°€ μ‚¬μš©μžκ°€ μž…λ ₯ν•œ νŒŒλΌλ―Έν„° 기반으둜 μˆœμ„œλŒ€λ‘œ μƒμ„±λ˜λ―€λ‘œ timeout된 operations도 μˆœμ„œλŒ€λ‘œ λ°˜ν™˜λ˜λ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.