search

naver / billboard.js

📊 Re-usable, easy interface JavaScript chart library based on D3.js
https://naver.github.io/billboard.js/
MIT License
5.77k stars 345 forks source link

Remove unused wheel listener #3791

Closed szendezsombor closed 4 weeks ago

szendezsombor commented 1 month ago

Description

src/ChartInternal/interactions/zoom.ts

        // Since Chrome 89, wheel zoom not works properly
        // Applying the workaround: https://github.com/d3/d3-zoom/issues/231#issuecomment-802305692
        $$.$el.svg.on("wheel", () => {});

This is resolved issue by the browser, can't be removed? (https://github.com/d3/d3-zoom/issues/231#issuecomment-819604071)

This cause warnings when zoom enabled:

image

Steps to check or reproduce

Create a chart with a zoom enabled, and it will show up. example

netil commented 1 month ago

Hi @szendezsombor, thanks for sharing. I'll go over it.