search

naver / dust3r

DUSt3R: Geometric 3D Vision Made Easy
https://dust3r.europe.naverlabs.com/
Other
4.66k stars 517 forks source link

Dockerize the project for nicer demo experience #19

Closed spagnoloG closed 3 months ago

spagnoloG commented 4 months ago

Maybe a cool addition to the project. If you have any suggestions to fix anything please do comment:)

jonppe commented 4 months ago

I think this would be good addition to the project.

Before noticing this PR, I already started doing my own non-conda version (https://github.com/jonppe/dust3r/commit/5089d1dcb867efd8556d4285a5eacc3a82c4bf41) but this was still helpful to find all the necessary apt packages. In fact there seems to be also another PR to add Dockerfile: https://github.com/naver/dust3r/pull/5

The non-conda installation feels somehow slightly more clean but I guess there's not much difference.

spagnoloG commented 4 months ago

I can try and integrate the venv version no problemo:) it looks cleaner yeah:) Thanks for pointing out!

spagnoloG commented 4 months ago

The image downloaded in the Dockerfile mentioned in pr #5 is kinda large (10GB) nvidia containers list. But lets use it as it has nvidia kernel options available (other image did not have them) and croco model can be successfully installed now.

spagnoloG commented 4 months ago

Now it is cleaned up thanks @jonppe <3 !

yocabon commented 3 months ago

Thanks a lot.