search

naver / dust3r

DUSt3R: Geometric 3D Vision Made Easy
https://dust3r.europe.naverlabs.com/
Other
4.65k stars 515 forks source link

when using swin in making pair, imgs will be maken pair with themselves #73

Closed DissipativeStructureObject closed 2 months ago

DissipativeStructureObject commented 2 months ago

in dust3r/image_pairs, about line 22 AE2}%N8F_LKZ~WXT6J{YUPM This can make j=0 in every loop, and then make idx=i. Finally, every img[i] will have a pair (img[i], img[i]) which is unnecessary and is harmful to final cloud point.

Maybe for j in range(1, winsize): will be more appropriate.

yocabon commented 2 months ago

Hi, thanks for the issue, it should be fixed now.