chore: add type definition file

naver / egjs-agent

Extracts browser and operating system information from the user agent string or user agent object(userAgentData).

https://naver.github.io/egjs-agent/

MIT License

110 stars 18 forks source link

chore: add type definition file #27

Closed tienne closed 5 years ago

tienne commented 5 years ago

This PR is associated with issue #26 added a type definition file to enable @ egjs / agent in typescript.

coveralls commented 5 years ago

Coverage remained the same at 93.525% when pulling 71fb953a9bfbd1c4951f6f9b36e965a1a9a158b5 on tienne:feature/type_definition into 9169cf7f823130eeaf1e90ce5f75053dd86bb7af on naver:master.

jongmoon commented 5 years ago

@tienne Maybe you missed it that I suggested following.

export default Agent;

instead of

export = Agent;

Could be possible?

tienne commented 5 years ago

@jongmoon Can you tell when the npm distribution will go into the merged version? Thank you

jongmoon commented 5 years ago

@tienne We will distribute the merged version after #29 is done. (It would be done within 2 days)

jongmoon commented 5 years ago

@tienne It's distributed~

tienne commented 5 years ago

@jongmoon Thank you for letting me know.