fix: call preventDefault only when it's cancelable

naver / egjs-axes

A module used to change the information of user action entered by various input devices such as touch screen or mouse into the logical virtual coordinates.

https://naver.github.io/egjs-axes/

MIT License

179 stars 32 forks source link

fix: call preventDefault only when it's cancelable #145

Closed WoodNeck closed 4 years ago

WoodNeck commented 4 years ago

Calling preventDefault when cancelable=false can produce error message in console.

[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, 
for example because scrolling is in progress and cannot be interrupted.

Issue: #147

CLAassistant commented 4 years ago

All committers have signed the CLA.

coveralls commented 4 years ago

Coverage increased (+0.01%) to 92.481% when pulling 7f57b1b36f9644adeae0030c260927a2717a651e on WoodNeck:check-event-cancelable into ffaaee425a02a138c851e08ef15a7e020a5dfee4 on naver:master.

stale[bot] commented 4 years ago

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

한글

이 이슈/PR은 commits, comments, labels, milestones 등 30일간 활동이 없어 자동으로 stale 상태로 전환되었습니다. 이후 7일간 활동이 없다면 자동으로 닫힐 예정입니다. 프로젝트 개선에 기여해주셔서 감사합니다.