naver / egjs-flicking

🎠 ♻️ Everyday 30 million people experience. It's reliable, flexible and extendable carousel.

https://naver.github.io/egjs-flicking/

MIT License

2.78k stars 129 forks source link

refactor: declare methods in methods instead of created #790

Open malangfox opened 1 year ago

malangfox commented 1 year ago

Issue

770

Details

This changes getPanels and getVirtualPanels to be initialized in methods instead of created. In some cases, such a warning appears because the methods declared in created are not recognized.

coveralls commented 1 year ago

Coverage: 79.337% (+0.1%) from 79.233% when pulling 15dae4035a683eabb96808ee6654fa937c66db13 on malangfox:refactor-vue3-methods into 761aa929d0a367442e4fcc867bf4c7ea92598241 on naver:master.

daybrush commented 1 year ago

LGTM

@malangfox Check if this is the case in vue2 as well.