search

naver / egjs-flicking

🎠 ♻️ Everyday 30 million people experience. It's reliable, flexible and extendable carousel.
https://naver.github.io/egjs-flicking/
MIT License
2.78k stars 129 forks source link

ngx-flicking 4.10.10 is broken directive styles under Angular V16 #815

Closed wen9218 closed 1 year ago

wen9218 commented 1 year ago

Description

Hi, ngx-flicking 4.10.10 is not working properly under ng v16. directive styles like flicking-camera, flicking-panels are broken. But ngx-flicking 4.10.10-beta.0 works well. Overall

Can you please check and fix it in the next version?

born2net commented 1 year ago

Hi... yes we are having the same issues, please let us know if you need more input. seems like from ngx-flicking 4.10.10-beta0 (works good) to 4.10.11-beta0 (broken) maybe changes need to be merged... thank you.

daybrush commented 1 year ago

@wen9218 @born2net

I'll check. It seems that the problem occurred when the angular version of the component was upgraded.

daybrush commented 1 year ago

@born2net @wen9218

Can you tell me how Flicking was imported and how it was used in the template?

wen9218 commented 1 year ago

@daybrush, I imported ngx-flicking module and used like this. Thanks for advancing.

image image

malangfox commented 1 year ago

Hello @wen9218.

We have released @egjs/ngx-flicking version 4.10.11, which fixes this issue. Can you check if the issue is reproduced in our latest version?

wen9218 commented 1 year ago

Hi, @daybrush, @malangfox, I checked v4.10.11. It works fine. Thanks a lot!

born2net commented 1 year ago

thank you!!!