naver / egjs-flicking

🎠 ♻️ Everyday 30 million people experience. It's reliable, flexible and extendable carousel.

https://naver.github.io/egjs-flicking/

MIT License

2.69k stars 129 forks source link

fix: fix threshold option not applying snap threshold #845

Closed malangfox closed 3 months ago

malangfox commented 5 months ago

Issue

844

Details

When determining the snapThreshold in _calcSnapThreshold, the value of the threshold option for the Flicking instance must be applied.
We didn't have a unit test that used vertical Flicking (DEFAULT_VERTICAL in a unit test) and this is the first time we've used it, I fixed it to be similar to the Flicking for other tests.

CLAassistant commented 5 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

malangfox seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

coveralls commented 5 months ago

coverage: 82.661% (+0.02%) from 82.638% when pulling 39b1edd3fd30a71476c685ea3063c3d360b146a9 on malangfox:fix-vertical-threshold into 3d528047f41adb7bd453430ce64fc3ceefc4a081 on naver:master.