naver / egjs-flicking

🎠 ♻️ Everyday 30 million people experience. It's reliable, flexible and extendable carousel.
https://naver.github.io/egjs-flicking/
MIT License
2.69k stars 129 forks source link

`renderOnlyVisible` option not working on documentation demo page. #869

Closed remyhunt closed 1 day ago

remyhunt commented 1 week ago

Description

Attempted to set the renderOnlyVisible option in my Vue3 app, and it didn't work.

I noticed this isn't working on the documentation page - suggesting that this might be a cross-platform issue!

https://naver.github.io/egjs-flicking/Options

Screenshot 2024-06-24 at 3 18 12 PM
malangfox commented 4 days ago

Hello @remyhunt.

When we checked the documentation page, we saw that renderOnlyVisible only renders the two Panels that fit inside the screen.

image

This seems to be different than Flicking above without the option applied, which renders 5 Panels, and we would like to check if there's something different if the demo works wrong in your environment.

Could you let us know how many Panels in the bottom Flicking renders in the developer tools in your environment?

remyhunt commented 1 day ago

thanks for getting back to me @malangfox - I had a misunderstanding of this option.

My expectation was that it was intended to change the behavior of the slider to instantaneously change, rather than use a slide animation. How embarrassing for me, but I appreciate your help!