search

naver / egjs-infinitegrid

A module used to arrange card elements including content infinitely on a grid layout.
https://naver.github.io/egjs-infinitegrid/
MIT License
2.23k stars 95 forks source link

Docs: API / Typedef / InfiniteGridOptions — repeating options #465

Closed nimmolo closed 2 years ago

nimmolo commented 2 years ago

Description

InfiniteGridOptions are inherited by FrameInfiniteGridOptions, JustifiedInfiniteGridOptions, MasonryInfiniteGridOptions, PackingInfiniteGridOptions, but some inherited options are listed twice in the front end tables for these four. Maybe just a copy/paste error.

horizontal percentage isEqualSize isConstantSize gap attributePrefix resizeDebounce maxResizeDebounce autoResize useFit useTransform renderOnPropertyChange preserveUIOnDestroy defaultDirection externalItemRenderer externalContainerManager

A little confusing — no big deal, but easy to fix. I will submit a PR now.

Steps to check or reproduce

See these tables. https://naver.github.io/egjs-infinitegrid/docs/api/FrameInfiniteGridOptions https://naver.github.io/egjs-infinitegrid/docs/api/JustifiedInfiniteGridOptions https://naver.github.io/egjs-infinitegrid/docs/api/MasonryInfiniteGridOptions https://naver.github.io/egjs-infinitegrid/docs/api/PackingInfiniteGridOptions https://naver.github.io/egjs-infinitegrid/docs/api/InfiniteGridOptions

daybrush commented 2 years ago

@nimmolo

Oh, Thank you :)

daybrush commented 2 years ago

@nimmolo

I solved this. Thank you :)