search

naver / egjs-infinitegrid

A module used to arrange card elements including content infinitely on a grid layout.
https://naver.github.io/egjs-infinitegrid/
MIT License
2.23k stars 95 forks source link

DOM Virtualisation appears broken with ScrollContainer attribute #577

Closed JohnRSim closed 1 month ago

JohnRSim commented 1 month ago

Description

When you add scrollContainer attribute the scroll functionality appears to work ie as you scroll down the data appends however there appears to be no cleanup functionality to clear out the DOM that is hidden that has been scrolled past. If you dont use the scrollContainer then this functions fine.

Steps to check or reproduce

Looking at this example

You can see the DOM is generated and not removed as you scroll to the bottom of the page the 1st grid item is still visible in the html structure.

Expectation only the elements visible should be displayed + a row above or below that are hidden to assist with the refresh - currently whole DOM structure remains.

Only tested with svelte integration.

JohnRSim commented 1 month ago

Had grouping in thousands - quickly fixed.