naver / egjs-view360

360 integrated viewing solution
https://naver.github.io/egjs-view360/
MIT License
497 stars 91 forks source link

Check browser support on SpinViewer #39

Closed jongmoon closed 7 years ago

jongmoon commented 7 years ago

Description

It's difficult to check if spinviewer is available. It's better to give a chance to check available. for example firing exception.

jongmoon commented 7 years ago
  1. Need feature detection for background-size style.

    • for example, Android 4.3 does not support background-size. image
  2. IE version must be larger than 8

jongmoon commented 7 years ago

Feature Tested

<script src="https://cdnjs.cloudflare.com/ajax/libs/es5-shim/4.1.5/es5-shim.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/es5-shim/4.1.5/es5-sham.js"></script>
jongmoon commented 7 years ago

It's related with pixel of jpeg image on Galaxy S6 Edge (Default Browser 3.0).

To tell the conclusion first,

Samsung Browser 3 (on S6 Edge - SM-G925S) cannot calculate size of image.

I tested following cases.

jongmoon commented 7 years ago

I think it is not proper to limit that browser because it can be used other case on that browser.

So let's make documentation for this issue.

jongmoon commented 7 years ago

Guide for this