React: Controls plugin is broken

naver / egjs-view360

360 integrated viewing solution

https://naver.github.io/egjs-view360/

MIT License

500 stars 90 forks source link

React: Controls plugin is broken #406

Closed GRA0007 closed 1 year ago

GRA0007 commented 1 year ago

Description

The Controls plugin in React renders two pie view elements, one of them is non-functional and very large. It also renders all the buttons even if not applicable to the platform, but they are missing icons.

Steps to check or reproduce

Using version 4.0.0-beta.4 of the React version
Simple example with Controls plugin

Codesandbox demo: https://codesandbox.io/s/egjs-view360-react-controls-q1u9cr

WoodNeck commented 1 year ago

@GRA0007 Hello, looks like this is a bug with React's StrictMode. I guess the plugins are not destroyed properly on unmount, I'll take a look at it.

WoodNeck commented 1 year ago

Fixed in 4.0.0-beta.5