search

naver / egjs

Javascript components group that brings easiest and fastest way to build a web application in your way.
https://naver.github.io/egjs
Other
935 stars 80 forks source link

Add new events on eg.Flicking #215

Closed incleaf closed 7 years ago

incleaf commented 8 years ago

Description

I've used another carousel library which supports beforeInit and afterInit event. Can you add these events on eg.Flicking? I think these are commonly used events for web component libraries.

sculove commented 8 years ago

@incleaf Thank you for your advice. We will talk about this issue. Could you tell me another carousel Plz.?

incleaf commented 8 years ago

I'm currently using OwlCarousel 1.x

On Tue, May 17, 2016, 11:56 Son Chan Uk notifications@github.com wrote:

@incleaf https://github.com/incleaf Thank you for your advice. We will talk about this issue. Could you tell me another carousel Plz.?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/naver/egjs/issues/215#issuecomment-219607016

netil commented 7 years ago

Sorry to be late on commenting.

We talked about this issue, but we decided to not add new initialization related custom events, because eg.Flicking is executed synchronously, so if you need some point to catch that moment, you can do without any custom event as below.


// <-- beforeInit: run some code at this point
var flicking = new eg.Flicking();
// <-- afterInit: run some code at this point

Anyway, thanks for your comment and interest. Any further comments and suggestion will be appreciated.

incleaf commented 7 years ago

Thank you for your kind comment. Your presentation on DEVIEW was really good 😄 I'll keep interest on egjs.