search

naver / egjs

Javascript components group that brings easiest and fastest way to build a web application in your way.
https://naver.github.io/egjs
Other
935 stars 80 forks source link

Check Disqus #223

Closed mixed closed 8 years ago

jongmoon commented 8 years ago

This issue is that disqus is not appeared in bottom of documentation(http://naver.github.io/egjs/latest/doc/)

image

The reason for this is that disqus info is not provided.

egjs uses egjs-jsdoc-template(https://github.com/naver/egjs-jsdoc-template) as a document automation tool. And egjs refers it on package.json.

 "devDependencies": {
    "browserstack-runner": "^0.4.1",
    "egjs-jsdoc-template": "*",
    "grunt": "^0.4.5",

But egjs-jsdoc-template does not have default setting for disqus in conf.json(https://github.com/naver/egjs-jsdoc-template/blob/master/conf.json).

"templates": {
        "disqus": "",

So we should update that information before documentation is built.

jongmoon commented 8 years ago

Ignore above reason.

egjs refers settings in EGJS-ROOT/jsdoc.json not the setting in egjs-jsdoc-template.

Real reason is as below.

egjs domain is not set up in disqus.

I've just created it (egjs.disqus.com). and I'll work like below.

image