search

naver / egjs

Javascript components group that brings easiest and fastest way to build a web application in your way.
https://naver.github.io/egjs
Other
935 stars 80 forks source link

egjs is not working in AMD #240

Closed sculove closed 8 years ago

sculove commented 8 years ago

Description

egjs has many dependencies. Especially, the eg,infiniteGrid needs to the outlayer and others. If your browser uses requirejs, you couldn't use egjs.

sculove commented 8 years ago

Libraries that the outlayer using do not support AMD. https://github.com/desandro/eventie/blob/master/eventie.js#L73

if ( typeof define === 'function' && define.amd ) {
  // AMD
  define( 'eventie/eventie',eventie );
} else if ( typeof exports === 'object' ) {
  // CommonJS
  module.exports = eventie;
} else {
  // browser global
  window.eventie = eventie;
}
sculove commented 8 years ago

ref. https://github.com/naver/egjs/issues/87

sculove commented 8 years ago

282