search

naver / egjs

Javascript components group that brings easiest and fastest way to build a web application in your way.
https://naver.github.io/egjs
Other
935 stars 80 forks source link

separate eg.agent from eg #323

Closed sculove closed 8 years ago

sculove commented 8 years ago

Description

eg.agent source is bigger and an agent isn't necessary for all egjs.

sculove commented 8 years ago

AS-IS

eg.agent() -> UAParser.create -> resultCache[eg] -> eg.hook

TO-BE

  1. all : eg move to eg.util
    • eg.blabla=> eg.utils.blabla => separate eg.utils
  2. only agent
    • eg.agent() => eg.Agent.create -> resultCache[eg] -> eg.hook
netil commented 8 years ago

Due to the division of agent as separate file, test files located on manual and unit folder, should be updated to include ./src/agent.js

sculove commented 8 years ago

@netil I miss manual folder. ok. thanks