search

naver / egjs

Javascript components group that brings easiest and fastest way to build a web application in your way.
https://naver.github.io/egjs
Other
937 stars 81 forks source link

feat(component): add once method #434

Closed mixed closed 7 years ago

mixed commented 7 years ago

Issue

Ref #412

Details

once is executed event just one time.

Preferred reviewers

@happyhj @jongmoon

mixed commented 7 years ago

@jongmoon Yes. We have to comply coding convetion. You have a feeling my code is wrong?

jongmoon commented 7 years ago

@mixed As below.

https://github.com/naver/egjs/pull/434/files#diff-36f2c7f7bbf377bdc2b3eacfa9332396R431

  ok( callCount, 1); //TOBE: ok(callCount, 1);

https://github.com/naver/egjs/pull/434/files#diff-36f2c7f7bbf377bdc2b3eacfa9332396R390

test("once method should be fire event one time.",function(){ // space is need before function()
mixed commented 7 years ago

@jongmoon Ah.... Thanks. I agree with you but currently Coding covention applied only source code. What do you think discuss this issue at next offline meeting?

jongmoon commented 7 years ago

@mixed no problem!

I think there would be many uncomplied source code.