naver / egjs

Javascript components group that brings easiest and fastest way to build a web application in your way.
https://naver.github.io/egjs
Other
935 stars 80 forks source link

When markup is already prepared, flicking saves other elements as children. #438

Closed sculove closed 7 years ago

sculove commented 7 years ago

Description

ref https://github.com/naver/egjs/issues/216

The flicking should save panels in eg-flick-container class. and find eg-flick-container under base element. now, flicking save all element under base element. and find only first index.

// _setConfig method
if ($children.eq(0).hasClass(options.prefix + "-container")) {
   this.$container = $children;
   $children = $children.children();
}

this code should change like this.

var $containers = $children.filter("." + options.prefix + "-container");
if ($containers.length) {
    this.$container = $containers.eq(0);
    $children = this.$container.children();
}

Steps to check or reproduce

<div id="mflick">
    <div class="spot_img_box eg-flick-container">
        <div>
            <div class="spot_img" style="background-image: url(./img/department_hyundai.jpg);"></div>
        </div>
        <div>
            <div class="spot_img" style="background-image: url(./img/department_lotte.jpg);"></div>
        </div>
        <div>
            <div class="spot_img" style="background-image: url(./img/department_ak.jpg);"></div>
        </div>
    </div>
    <div class="spot_item_box">
        <div class="spot_item selected _1">
            <a href="#" class="lnk_branch">
                <span class="ico_arr"></span>
                <span class="en">HYUNDAI0</span>
            </a>
        </div>
        <div class="spot_item _2">
            <a href="#" class="lnk_branch">
                <span class="ico_arr"></span>
                <span class="en">LOTTE1</span>
            </a>
        </div>
        <div class="spot_item _3">
            <a href="#" class="lnk_branch">
                <span class="ico_arr"></span>
                <span class="en">AK PLAZA2</span>
            </a>
        </div>
        <div class="spot_item _4">
            <a href="#" class="lnk_branch">
                <span class="ico_arr"></span>
                <span class="en">LOTTE9</span>
            </a>
        </div>
    </div>
    <div class="spot_navi_bar">
    </div>
    <div class="spot_cont_box">
        <div class="item_source selected">
        </div>
        <div class="item_source">
        </div>
        <div class="item_source">
        </div>        
    </div>
</div>
new eg.Flicking("#mflick")