search

naver / egjs

Javascript components group that brings easiest and fastest way to build a web application in your way.
https://naver.github.io/egjs
Other
935 stars 80 forks source link

Ambiguity of getting elements #467

Closed netil closed 7 years ago

netil commented 7 years ago

Description

Getting top/bottom elements API description and return value has ambiguity.

Returns a card element at the top of a layout.

Returns a card element at the bottom of a layout.

The descriptions are likely saying getting result of top or last element, but if grids are divided in several columns, which one is the expected?

For example, in the following case, .getBottomElement(), return the right element? or the left?

image

sculove commented 7 years ago

I will add jsdoc comment.

sculove commented 7 years ago

The last element is used to find the index of the next data to fetch. we should fix it.