naver / egjs

Javascript components group that brings easiest and fastest way to build a web application in your way.
https://naver.github.io/egjs
Other
935 stars 80 forks source link

MovableCoord::_getCicularPos() is not circular perfectly. #481

Closed jongmoon closed 7 years ago

jongmoon commented 7 years ago

Description

This function makes holes on boundary value.

Steps to check or reproduce

For example,

getCircularPos([6, 0], [-5, 0], [5, 0], [true, true, true, true])

It returns-5, The how about below result?

getCircularPos([-6, 0], [-5, 0], [5, 0], [true, true, true, true])

It returns 4

The return rules are different each other!

sculove commented 7 years ago

applied 2.0.0-rc.1