Closed this-is-spear closed 6 months ago
I modified the PR topic because the focus was on the work done to get the Value class creation working correctly. I believe one of the subtasks was to fix the Duration class to work correctly.
I thought it needed to be fixed in order to see and understand the git history.
If you need to change to the previous topic, please let me know. I'll fix it. ☺️
It's all thanks to the maintainer's help! I learned a lot 🙇♂️
Summary
962
Fixed to use kotlin duration in the set function.
(Optional): Description
Fixed
NodeSetDecomposedValueManipulator
throwing an exception because the object node and value class types did not match.Fixed an issue in
PrimaryConstructorArbitraryIntrospector#resolveArbitrary
where when injectingDuration
, it was trying to inject Duration class as Duration because Duration is a value.As we progressed, there was an issue where the value class didn't have its own type and the operation was proceeding. So we fixed the code so that the value class can continue working with its own type.
How Has This Been Tested?
To test Duration, we added or reused the validation logic below.
PrimaryConstructorArbitraryIntrospectorTest#setDurationValue
.PrimaryConstructorArbitraryIntrospectorTest#sampleDurationValue
.PrimaryConstructorArbitraryIntrospectorTest#sampleDuration
.To test Value class, we added or reused the validation logic below.
ValueClassTest#foo
ValueClassTest#valueClassProperty
ValueClassTest#setValueClassProperty
Is the Document updated?
We didn't update the documentation because there were no feature changes.