Fix simple value plugin constuctor

naver / fixture-monkey

Let Fixture Monkey generate test instances including edge cases automatically

https://naver.github.io/fixture-monkey

Apache License 2.0

575 stars 90 forks source link

Fix simple value plugin constuctor #987

Closed Ting-Kim closed 5 months ago

Ting-Kim commented 5 months ago

Summary

Describe what feature is implemented by this PR. If there is a related issue, write the issue number and link

Resolves #986

(Optional): Description

Describe your changes in detail

Fixed a problem with the order of parameters injected when creating an instance of SimpleValueJqwikPlugin in the accept() method within the SimpleValueJqwikPlugin class.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

to verify the scenario that was reproduced in the #986 issue.

CLAassistant commented 5 months ago

All committers have signed the CLA.

Ting-Kim commented 5 months ago

@seongahjo I've reflected, could you please check? ☺️

seongahjo commented 5 months ago

It's perfect. Thank you for your contributing!

Ting-Kim commented 5 months ago

It's perfect. Thank you for your contributing!

Thanks for the help. I would be very happy if I could continue to contribute ☺️

Plus, I have a question. It would be nice if validation logic was in the creator to prevent this issue from happening again, do you have any related conventions or anything?

seongahjo commented 5 months ago

@Ting-Kim

Thanks for the help. I would be very happy if I could continue to contribute

Of course, we'd love to hear from you!

It would be nice if validation logic was in the creator to prevent this issue from happening again, do you have any related conventions or anything?

I think it is better to validate SimpleJavaConstraintGenerator in its constructor, since SimpleJavaConstraintGenerator is not inherited unless really needed.

Ting-Kim commented 5 months ago

@seongahjo I see. Thank you very much for your answer. :)