search

naver / kapture

kapture is a file format as well as a set of tools for manipulating datasets, and in particular Visual Localization and Structure from Motion data.
BSD 3-Clause "New" or "Revised" License
466 stars 66 forks source link

Bug in import from bundler #10

Closed ducha-aiki closed 3 years ago

ducha-aiki commented 3 years ago

Hi,

I have tried to import from bundler and experienced problems. I am still in the process of debugging, but this two lines seems wrong for sure - x and y are looking into the same value

https://github.com/naver/kapture/blob/4a67f434585db3112ef24c81faf3831fc3fc397c/tools/kapture_import_bundler.py#L175 https://github.com/naver/kapture/blob/4a67f434585db3112ef24c81faf3831fc3fc397c/tools/kapture_import_bundler.py#L176

yocabon commented 3 years ago

Hi, there was indeed an error with the locations of the keypoints, thanks.

What's the error that you got ? it's not a format that we use, it was implemented from specifications with only one example file so it's possible some things were not taken into account.

ducha-aiki commented 3 years ago

I am in the process of debugging yet :) Once I will have a working example, I will come back here and tell the full story/submit corrections and on.

humenbergerm commented 3 years ago

Thanks for finding the bug!