search

naver / mast3r

Grounding Image Matching in 3D with MASt3R
Other
1.31k stars 98 forks source link

About test_criterion #44

Open wuqun-tju opened 1 month ago

wuqun-tju commented 1 month ago

Hello, I wanna know why the sign of MatchingLoss in the test_criterion is negtivate:

Regr3D(L21, norm_mode='?avg_dis', gt_scale=True, sky_loss_value=0) + -1.*MatchingLoss(APLoss(nq='torch', fp=torch.float16), negatives_padding=12288)"

yocabon commented 1 month ago

Hi, the comment in the code about the APLoss was wrong, it returns AP, not 1-AP. Since for AP, higher is better, and it is the opposite for Regr3D, it's logical that the loss is Regr3D - AP.