naver / ngrinder

enterprise level performance testing solution
naver.github.io/ngrinder
Apache License 2.0
2k stars 478 forks source link

Add CI github actions #906

Closed imbyungjun closed 2 years ago

imbyungjun commented 2 years ago

now it's on test

junoyoon commented 2 years ago

Good!!!!!!!

imbyungjun commented 2 years ago

When running unit test on Github Actions, the "testAdditionalAuthenticationChecks" test is failed. If run the tests in org.ngrinder.security packages only, all the tests are succeed. If run all the tests in ngrinder-controller module, the only one test, "testAdditionalAuthenticationChecks" is failed.

It seems like an issue caused by modifying security context on the other test. But, it's pretty hard to find out.

imbyungjun commented 2 years ago

Test was crashed becuase the test user account's password was encoded twice.

Default test user information

And the encoded password when the test is failed is b525fa2966b3f37e91f4cb66534c5630c8d363d7 which is SHA-1 hash result of c96aadc66c909133e634a4f19f255290a00cd83d{TEST_USER}.

After removing the updating test user account having password, the test "testAdditionalAuthenticationChecks" will success.

github-actions[bot] commented 2 years ago

✅ Build & Test workflow succeed ✅