naver / splade

SPLADE: sparse neural search (SIGIR21, SIGIR22)
Other
737 stars 80 forks source link

move all source to splade/ module #17

Closed cmacdonald closed 2 years ago

cmacdonald commented 2 years ago

Hi,

I'd like to build client code that depends on SPLADE. Please would you consider this PR, which moves all source code into a splade folder, rather than a src/ folder. This appears to work satisfactorily for my use case.

Craig

thibault-formal commented 2 years ago

Hi Craig, thanks for the PR! I've made a bunch of fixes, otherwise everything looks good to me! @cadurosar if you can have a look, then we can merge

Thibault

cmacdonald commented 2 years ago

Excellent, thanks Thibault!