naver / splade

SPLADE: sparse neural search (SIGIR21, SIGIR22)
Other
751 stars 84 forks source link

Python version 3.8 or 3.9? #30

Closed KevinColemanInc closed 1 year ago

KevinColemanInc commented 1 year ago

The requirements section in the ReadMe.md says 3.9 https://github.com/naver/splade/blob/main/README.md?plain=1#L55

But conda env says 3.8 https://github.com/naver/splade/blob/main/conda_splade_env.yml#L128

Which is preferred?

cadurosar commented 1 year ago

I would say that 3.8 is preferred, but we have used both. I think me and @thibault-formal discussed a bit on this, but I don't remember, do you remember Thibault?

KevinColemanInc commented 1 year ago

I only tried 3.9 on my m1 and it worked.

thibault-formal commented 1 year ago

hi, strange, I don't know why there is this mismatch. From my experience, both are working.

thibault-formal commented 1 year ago

we will try to clarify, closing the issue.