naver / splade

SPLADE: sparse neural search (SIGIR21, SIGIR22)
Other
751 stars 84 forks source link

PyTorch version checking #54

Closed Lameus closed 5 months ago

Lameus commented 7 months ago

This line https://github.com/naver/splade/blob/692276db75bc274d584d33661ac693a0af050a17/splade/tasks/amp.py#L5 doesn't work properly just because there are versions over 1.6 that are less than 1.6 numerically. For example, versions >= 1.10