naver / sqlova

Apache License 2.0
632 stars 168 forks source link

Missing quotes in Where clause #12

Open AbhinavSke opened 5 years ago

AbhinavSke commented 5 years ago

I modified the code for making predictions for a user query. But in the generated SQL query, 'text' datatypes do not have quotes around them in the Where clause.

Basically, I get

'SELECT avg(sentiScore) FROM review_data WHERE product = pizza'

Instead of generating

'SELECT avg(sentiScore) FROM review_data WHERE product = "pizza" '

Is there something that I'm missing? Or is this the limitation of the DL approach?

zyc1310517843 commented 5 years ago

我修改了用于为用户查询进行预测的代码。但是在生成的SQL查询中,'text'数据类型在Where子句中没有引号。

基本上,我明白了

'SELECT avg(sentiScore)FROM review_data WHERE product = pizza'

而不是生成

'SELECT avg(sentiScore)FROM review_data WHERE product =“pizza”'

有什么东西我不见了吗?或者这是DL方法的限制?

Hello, have you successfully run the author's code? How to test with your own data? I hope I can get your help. Thanks again.