search

naver / storybook-addon-preview

Storybook Addon Preview can show user selected knobs in various framework code in Storybook
https://naver.github.io/egjs-infinitegrid/storybook/
MIT License
66 stars 10 forks source link

feat: Support Storybook v6 Controls #13

Closed metasean closed 4 years ago

metasean commented 4 years ago

addresses issue #12

Adds support for Storybook v6 Controls which are a Storybook default add-on that will be completely replacing the knobs add-on in future versions of Storybook.

I was only able to test against my new v6 Storybook, as a result, I couldn't test whether the absence of any Controls would cause problems. So, please test thoroughly for backwards compatibility!

Also, I saw a fair bit of knob related code in index.tsx, but everything appears to be working okay for me without any modifications to that file. 🤷

daybrush commented 4 years ago

@metasean

Thank you so much for your pr. After discussing, we will merge.