navgurukul / bhanwari-devi

Frontend Repository for Merakilearn maintained by Navgurukul students and volunteers
https://www.merakilearn.org/
31 stars 17 forks source link

fix: Don't have responses from `/pathways` and `/pathways/dropdown` overwrite each other in Redux state #1013

Closed jschanker closed 1 year ago

jschanker commented 1 year ago

Which issue does this refer to ? Responses from GET /pathways and GET /pathways/dropdown are currently being stored in the same places in the slices of Redux state causing one to overwrite the other.

Brief description of the changes done A brief step by step changes made. Example :

  1. Split the single reducer into two and updated the exports.
  2. Updated the import in the root reducer, accordingly to use these two different reducers, so they're stored in different slices of state.

Didn't check other pieces of reliant code or test, so this may have caused issues

People to loop in / review from Use @ key to tag people to review from

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bhanwari-devi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 0:38am
bhanwari-devi-old ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 0:38am
meraki-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 0:38am
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication