navgurukul / bhanwari-devi

Frontend Repository for Merakilearn maintained by Navgurukul students and volunteers
https://www.merakilearn.org/
31 stars 17 forks source link

Clicking back button scrolls the page to the top #704

Open saquibaijaz opened 2 years ago

saquibaijaz commented 2 years ago

Describe the bug If a user clicks on the course module and the clicks back button, the page is scrolled to the top.

To Reproduce

  1. User clicks on a course module inside a learning track
  2. User is redirected to the login page
  3. User clicks the back button
  4. User is redirected to the course module page but the page is scrolled to the top (For all the learning tracks)

Expected behaviour User is redirected to the course module page and to the same position where he was previously at.

Screencast https://drive.google.com/file/d/1HuTzElct9owhWMPufTOijC9jVCnWLmrd/view?usp=sharing

Refer Sheet TC for Landing page without login (website), Test case 14.2

kartiks26 commented 2 years ago

@saquibaijaz its been implemented As a feature , Like what yoused to happen on home screen the learning track was preety down and when you been using the course content you do next it was not getting to top as it should ideally so in pathway change its just scrolls to top . we can remove that but might halt the experience in course content

saquibaijaz commented 2 years ago

@kartiks26 , I'll confirm again and will let you know

Poonam-Singh-Bagh commented 2 years ago

@saquibaijaz can we get the update? Do remove this feature or what?

saquibaijaz commented 2 years ago

@kartiks26 @Poonam-Singh-Bagh I got this reply in the requirements call, "not fit for content, other places they should maintain the state" Means, when we are on assessments and looking at the content then scroll to top is fine, but when we are anywhere else on our website other than the content, then it should not scroll to top when back button is hit