naviapps / create-nw-react-app

Create NW.js React apps with no build configuration.
MIT License
144 stars 14 forks source link

Update package.json in nw-react-scripts #64

Closed syehoonkim closed 1 year ago

syehoonkim commented 1 year ago

nw-builder 3.8.6 has lost dependency(nw-install), so the version should be the latest 4.2.3

oallouch commented 1 year ago

Without this PR, the project is broken.

oallouch commented 1 year ago

It doesn't fully work. For my project to start, I had to changed scripts/start.js a bit (without really knowing what I was doing).

image

naviapis commented 1 year ago

It may not read the new nwbuilds parameter in your package.json, so your changes may not be sufficient. https://github.com/naviapps/create-nw-react-app/issues/63#issuecomment-1569546578 In addition, nw-builder v4 is not compatible with v3, and unfortunately parameters have changed.

oallouch commented 1 year ago

Works like a charm now. Thx a lot