naviapps / create-nw-react-app

Create NW.js React apps with no build configuration.
MIT License
144 stars 14 forks source link

Error when running build - cant find rcedit-x64.exe #67

Open noah-sinnott opened 1 year ago

noah-sinnott commented 1 year ago

When running npm run build i get this error

[ WARN ] 2023-07-02T12:26:23.463Z Renaming EXE failed or unable to modify EXE. If it's the latter, ensure WINE is installed or build in Windows [ ERROR ] 2023-07-02T12:26:23.463Z Error executing command (C:\Users\noahs\Documents\code\personal repos\reseller-desktop\node_modules\nw-builder-platforms\bin\rcedit-x64.exe C:\Users\noahs\Documents\code\out\win64\nw-react-scripts.exe --set-version-string FileVersion 0.1.0 --set-version-string InternalName nw-react-scripts --set-version-string OriginalFilename nw-react-scripts --set-version-string PrivateBuild nw-react-scripts --set-version-string ProductName nw-react-scripts --set-version-string SpecialBuild nw-react-scripts --set-icon ,../cnra-template/src/logo.icns): spawn C:\Users\noahs\Documents\code\personal repos\reseller-desktop\node_modules\nw-builder-platforms\bin\rcedit-x64.exe ENOENT The system cannot find the path specified.

I am running vscode in windows 11, i have checked and powershell is running in admin mode too. node version 16.13.2. npm run start works fine aswell

here is my package.json { "name": "reseller-desktop", "version": "0.1.0", "private": true, "dependencies": { "@emotion/react": "^11.10.6", "@emotion/styled": "^11.10.6", "@mui/icons-material": "^5.11.16", "@mui/material": "^5.12.1", "@testing-library/jest-dom": "^5.16.5", "@testing-library/react": "^11.2.7", "@testing-library/user-event": "^12.8.3", "nw-react-scripts": "^5.1.1", "path": "^0.12.7", "react": "^18.2.0", "react-dom": "^18.2.0", "react-modal": "^3.16.1", "react-router-dom": "^6.10.0", "react-select": "^5.7.2", "web-vitals": "^1.1.2" }, "scripts": { "start": "nw-react-scripts start", "build": "nw-react-scripts build", "test": "nw-react-scripts test", "eject": "nw-react-scripts eject" }, "eslintConfig": { "extends": [ "nw-react-app", "nw-react-app/jest" ] }, "browserslist": { "production": [ ">0.2%", "not dead", "not op_mini all" ], "development": [ "last 1 chrome version", "last 1 firefox version", "last 1 safari version" ] }, "main": "index.html", "nwbuilds": { "//": "https://nwutils.io/nw-builder/", "platforms": [ "win64" ], "version": "latest", "flavor": "normal", "outDir": "../../out", "cacheDir": "../../cache", "app": { "name": "nw-react-scripts", "icon": ",../cnra-template/src/logo.icns" } }, "window": { "maximizable": true, "frame": false } }

Ibrvheem commented 8 months ago

Hello, were you able to fix this?

noah-sinnott commented 8 months ago

No, Had to switch to electron

Ibrvheem commented 8 months ago

Lol. I did the exact same thing.

Thanks @noah-sinnott

boly38 commented 6 months ago

today I just try

$ npx create-nw-react-app my-nw-app

then startwas (long and) ✅ ok, but a simple build was 🔴 failed :'(

I got the following error ENOENT

  code: 'ENOENT',
  syscall: 'link',
  path: 'C:\\WORK\\perso\\tmp\\my-nw-app\\Versions\\Current\\Resources',
  dest: 'C:\\WORK\\perso\\tmp\\my-nw-app\\cache\\osx64\\nwjs-v0.83.0-osx-x64\\nwjs.app\\Contents\\Frameworks\\nwjs Framework.framework\\Resources',

wait I'm on windows 64 so I removed "osx64", "win32", from package.json (::nwbuilds::platforms) and then retry npm run build :

image

I then got the error you're talking about.

But I noticed that the return code is 0 and the win64 executable works well.

$ echo $?
0

$ ./out/win64/my-nw-app.exe
(app ok)

I do expect :

MegalithOfficial commented 5 months ago

Is there any updates to solve the issue ? Im having the same issue right now.