Fix Lastfm api config missing

navidrome / navidrome

🎧☁️ Modern Music Server and Streamer compatible with Subsonic/Airsonic

https://www.navidrome.org

GNU General Public License v3.0

10.48k stars 798 forks source link

Fix Lastfm api config missing #2905

Closed hazre closed 2 months ago

hazre commented 3 months ago

I haven't tested this, but looks like in commit https://github.com/navidrome/navidrome/commit/1f71e567411103486fbc24f9820323283742bc4b the config for Lastfm api was accidently removed, which causes this line below to fail https://github.com/navidrome/navidrome/blob/859cdda0bdaa67cc92e8312c2be13f12cb89fddb/ui/src/authProvider.js#L24

~~I will try to build and test this in a bit.~~

fixes #2896

hazre commented 3 months ago

Okay I've verfied it. This fixes lastfm integration. Clicking "Scrobble to Last.fm" opens the link with the api key (no more null) and playing songs shows up in Lastfm.

deluan commented 2 months ago

Thanks for the PR, but please take a look at https://github.com/navidrome/navidrome/issues/2896#issuecomment-2033316873

I'll close this, but if you have any other concern, please reply in the issue.