navidrome / navidrome

🎧☁️ Modern Music Server and Streamer compatible with Subsonic/Airsonic
https://www.navidrome.org
GNU General Public License v3.0
10.17k stars 783 forks source link

Feat/lastfm use album artist #2909

Open felipemarinho97 opened 2 months ago

felipemarinho97 commented 2 months ago

Adding a config to allow scrobble the albumArtist instead of artist. This is because some songs with various artists are being scrobbled wrongly.

Now (artist tag): Screenshot from 2024-03-14 08-54-20

With the albumArtist: Screenshot from 2024-03-14 08-53-34

This change do not break anything. The default value for UseAlbumArtist is false.

Also, I dind't find where I can update these docs (https://www.navidrome.org/docs/usage/configuration-options/).

certuna commented 2 months ago

This will introduce wrong scrobbles for tracks from compilation albums that have the compiler or DJ credited as the Album Artist, like Jamiroquai - LateNightTales or Bob Stanley & Pete Wiggs - Winter Of Discontent.

IMO this problem will solve itself when Navidrome will support multiple artists (this is planned, @deluan is working on the database refactoring that makes this possible), then you could write an option for the scrobbler code to choose between the first Artist of the array ("Bob", "Alice") or the whole Artist string ("Bob feat. Alice")

felipemarinho97 commented 1 month ago

This will introduce wrong scrobbles for tracks from compilation albums that have the compiler or DJ credited as the Album Artist, like Jamiroquai - LateNightTales or Bob Stanley & Pete Wiggs - Winter Of Discontent.

IMO this problem will solve itself when Navidrome will support multiple artists (this is planned, @deluan is working on the database refactoring that makes this possible), then you could write an option for the scrobbler code to choose between the first Artist of the array ("Bob", "Alice") or the whole Artist string ("Bob feat. Alice")

Well, this is a trade off.. If you listen to a lot of compilations and care about it, just leave the config UseAlbumArtist as false (this is the default).

inalone commented 1 month ago

Great work - I'd love this in master.