Closed michaelkrieger closed 3 weeks ago
MRodneyMcKay
commented
3 weeks ago Hope that this bugreport will be more successfull, than my feature request. I would like to use jukebox mode on a truenas app, and their support says thatonce mpv is present at the docker, they can experiment with sound devices, playback modes, but until then, they cannot do anything
deluan
commented
3 weeks ago Adding MPV to the image increases its size considerably: Current:
deluan/navidrome develop 4a7c5af5cb83 6 minutes ago 173MBWith MPV:
deluan/navidrome develop c1dda16003ca 7 seconds ago 246MBI don't think it is worthy adding it by default, as most users don't use the Jukebox mode.
Ideally we would have to change the pipeline/release process to add a new Docker image variant, including MPV. Contributions are most welcome :)
In the meantime, you could create your own image, by using this simple Dockerfile:
FROM deluan/navidrome:latest
RUN apk add --no-cache mpv
michaelkrieger
commented
3 weeks ago Adding MPV to the image increases its size considerably I do wonder if all the dependencies are required for this purpose, as MPV isn’t huge in itself. I’ll have a look at what is required.
Ideally we would have to change the pipeline/release process to add a new Docker image variant, including MPV. Agreed. A new tag with MPV is helpful.
Also, I’m not sure disk size is a huge consideration for most folks on container size, but I understand wanting a small core container.
MRodneyMcKay
commented
3 weeks ago I don't think it is worthy adding it by default, as most users don't use the Jukebox mode.
Right now, the app has a feature, which, ideally, should be supported on all platforms.
Adding MPV to the image increases its size considerably:
I understand your consertn about needlessly increase the image size, with, arguably bloat. However, there are certain usecases, (like on TrueNAS), where you cannot really edit the docker. Would it really be that hard and resource intensive, to publish another docker train, with jukebox support? So itnot only contains MPV, but all relevant config to make it actually work (a simple direct strem to an ALSA device, no need to play with pulse sockets/pipes). How can I contribute to the release proccess, so it would work?
deluan
commented
3 weeks ago where you cannot really edit the docker.
I'm not suggesting editing an image, but to create your own using the Dockerfile mentioned above.
Would it really be that hard and resource intensive, to publish another docker train, with jukebox support?
Is not that hard, but it is also not free. Remember, this is an open source project that I work on in my spare time...
So itnot only contains MPV, but all relevant config to make it actually work (a simple direct strem to an ALSA device, no need to play with pulse sockets/pipes). How can I contribute to the release proccess, so it would work?
I decided to add mpv to the image, as you can see in ca005f6457fcd57f5fb8abb731fc947d44b880. In the end, using Alpine 3.18, it only added ~20MB uncompressed (~10%). But I don't have any means to test it on TrueNAS, so feel free to contribute with changes required to make it work.
MRodneyMcKay
commented
3 weeks ago Thank you, this works great in a docker in arch! From now on, we will need to work on the Truenas app release/config. This commit solved our issue, this can get merged, if it is alright
I confirm that:
Version
0.51.1
Current Behavior
Expected Behavior
Docker container should have
mpvto enable jukebox mode for architectures where it is supported. Alpine mpv packages exist.Steps To Reproduce
We can use jukebox mode in docker by either passing
/dev/sndto the container (for exclusive use by navidrome) or ideally passing the pulseaudio socket at/run/user/1000/pulse(for non-exclusive use of the audio output which is more friendly to other system applications).The dockerfile should be updated to add the mpv package to the container by default.
Environment
How Navidrome is installed?
Docker
Configuration
relevant excerpt
Relevant log output
Anything else?
Once this is done, mpv exists and can see all of the sound devices on the system, though navidrome has already tried to enumerate devices and doesn't show any in the web interface.
Alternately, the documentation should be updated to advise whether this is not supported in a docker configuration. Right now, jukebox mode doesn't work in docker, but there is no mention of this or why.
Code of Conduct