navidrome / navidrome

🎧☁️ Modern Music Server and Streamer compatible with Subsonic/Airsonic
https://www.navidrome.org
GNU General Public License v3.0
11.33k stars 843 forks source link

Artist List view based on standard React Admin template #847

Closed certuna closed 1 year ago

certuna commented 3 years ago

Replace the current bare-bones Artist view with one based on this one from the React Demo website:

Screen Shot 2021-03-15 at 18 07 46

We should probably stick close to this boilerplate component to minimize the work, but even within those boundaries there should be some good functionality to be added here (please contribute if you have other ideas, or really dislike these):

Columns

Filters

Search

rohitgeddam commented 3 years ago

This looks like a good enhancement, I will give it a try!

ruddi10 commented 3 years ago

@deluan can you assign this to me

certuna commented 3 years ago

Bear in mind that this is not only front end work

ruddi10 commented 3 years ago

Okk

rohitgeddam commented 3 years ago

artist_api

We would like to display the artist image on the artist tab however, the API is returning an empty string

"smallImageUrl": "",
"mediumImageUrl": "",
"largeImageUrl": "",

how should we fetch the artist image?

deluan commented 3 years ago

Artist metadata is handled on the server side. We don't want the UI talking to external services (and potentially introducing some privacy issues).

If (and only if) the image URLs are empty, you can retrieve them using the getArtistInfo2 api call: http://subsonic.org/pages/api.jsp#getArtistInfo2

The problem is that it may take too long to request all images on first load. I have a plan to populate these images in background using a worker pool, but it is not implemented yet.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please tell us why. This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.