search

navidrome / website

Navidrome's documentation website
https://www.navidrome.org
Apache License 2.0
18 stars 101 forks source link

Update Docs for LastFM #170

Open rightsaidfred99 opened 1 month ago

rightsaidfred99 commented 1 month ago

It might be useful to edit the tutorial to add this in below for noobs like me. Currenty the tutorial just ends but doesn't explicitly state how to configure the external apps

environment: LASTFM_APIKEY: "x" LASTFM_SECRET: "x" SPOTIFY_ID: "x" SPOTIFY_SECRET: "x"

rightsaidfred99 commented 1 month ago

Also the page links to the wrong way to create an API account for last fm?

After doing it all I get is

Invalid API key. If you are a third party developer see our authentication how-to to find out more.

Demon-Sheriff commented 1 month ago

I would like to work on this issue.

deluan commented 1 month ago

@rightsaidfred99, thanks for your suggestions. I'm all for making the documentation clearer, but I don't see an issue here. In the External Integrations page, it already mention the options that need to be configured:

LastFM:

For these features to work, you’ll need to set the config options LastFM.ApiKey and LastFM.Secret

Spotify:

You’ll need to set the config options Spotify.ID and Spotify.Secret

The page also contains a link to the config options page. This page explains how to setup any configuration in Navidrome.

By the way, that page explains that config options should be named as they appear in the page, so the correct name to add to the configuration file is LastFM.ApiKey, not LASTFM_APIKEY. If you need to set it as an environment var, you must add the ND_ prefix, so the correct name for an environment variable is ND_LASTFM_APIKEY.

Regarding the issues you are facing:

Also the page links to the wrong way to create an API account for last fm?

Which link is wrong? I was able to follow the link and don't see any issue.

Invalid API key. If you are a third party developer see our authentication how-to to find out more

Where do you see this error message? If it is in Navidrome, I think it is better to ask for help in Navidrome's main discussion board: https://github.com/navidrome/navidrome/discussions/categories/q-a