search

navigating-stories / orange-story-navigator

Add-on to the Orange3 data mining toolkit with text processing widgets from the project Navigating Stories
https://research-software-directory.org/projects/navigating-stories
Other
2 stars 2 forks source link

Move build config to pyproject.toml #67

Closed stefsmeets closed 3 weeks ago

stefsmeets commented 1 month ago

This PR moves the build config to pyproject.toml. I also cleaned up a few files.

Closes #63

Todo

stefsmeets commented 4 weeks ago

Hi @kodymoodley @ThijsVroegh Any chance we could get this reviewed and merged? 😅

kodymoodley commented 3 weeks ago

Hi @stefsmeets, does this change in the build config affect the deployment of new versions of the add-on? I have setup some Github actions to automatically deploy to PyPI whenever a new release is made. Also I am not sure but I think the readthedocs depends on some of the current build config.

stefsmeets commented 3 weeks ago

Hi @kodymoodley you still do pip install -e . or pip install storynavigator to install the package, if that is what you mean.

The rtd build is separate from the build system, although it will use this code to install the package. I think it also just does pip install .. If there is an unforeseen breakage I will fix it.

Once this is merged I plan to have a look at the automated deploy to pypi etc in #65

kodymoodley commented 3 weeks ago

Hi @kodymoodley you still do pip install -e . or pip install storynavigator to install the package, if that is what you mean.

The rtd build is separate from the build system, although it will use this code to install the package. I think it also just does pip install .. If there is an unforeseen breakage I will fix it.

Once this is merged I plan to have a look at the automated deploy to pypi etc in #65

Okay @stefsmeets glad to know you can fix if there is a breakage. You can go ahead and merge then.