issue54, changed ids to numeric - Githubissues

navigating-stories / orange-story-navigator

Add-on to the Orange3 data mining toolkit with text processing widgets from the project Navigating Stories

https://research-software-directory.org/projects/navigating-stories

Other

2 stars 2 forks source link

issue54, changed ids to numeric #68

Closed ThijsVroegh closed 3 weeks ago

ThijsVroegh commented 4 weeks ago

Issue

Resolves issue #54: output sentences of the Actors widget were presented in the wrong order

Description of changes

We (TV + ET) fixed two problems:

story id and sentence_id columns in story_elements_df were strings before sorting on line 217 in file actoranalysis.py which caused unexpected orderings. The format was changed to integer
only one of sentences with identical text were kept on line 218 in file actoranalysis.py . This was fixed by considering storyid and sentence_id as well when checking for duplicates

Includes

[X] Code changes
[ ] Tests
[ ] Documentation

ThijsVroegh commented 3 weeks ago

Hi @kodymoodley, could you also review and merge this one? 😅 It's only a small fix so should't take too long

ThijsVroegh commented 3 weeks ago

Hi @kodymoodley, perfect! I will do a couple of additional checks before merging..