navikt / aksel

NAVs designsystem og Aksel-portalen
https://aksel.nav.no
MIT License
158 stars 42 forks source link

[Darkside] Loader CSS update #3355

Closed KenAJoh closed 5 days ago

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: a6ca8b38eedb47bbd2ce7bd45a98046ff603a4d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 week ago

Storybook demo

6acbd0937 | 91 komponenter | 135 stories

HalvorHaugan commented 1 week ago

Still WIP?

KenAJoh commented 1 week ago

Member

No, should be good-to-go

HalvorHaugan commented 1 week ago

I get some weird shaking in Chrome 😅

https://github.com/user-attachments/assets/7a9b1b57-a493-4777-b653-1898b7010a30

Only seems to happen when there are multiple loaders, so I don't think we need to worry about it.

KenAJoh commented 1 week ago

I get some weird shaking in Chrome 😅

@HalvorHaugan Is this new in this PR, or the case with the old loader to?

HalvorHaugan commented 1 week ago

Only with the new darkside css in this PR

KenAJoh commented 1 week ago

@HalvorHaugan So strange, no changes were made to how this were handled 🤔 Does it change if you remove stroke-linecap: round; in this CSS? That should be the only actual change

.navds-loader__foreground {
  animation: loader-dasharray 1.5s ease-in-out infinite;
  stroke-dasharray: 80px, 200px;
  stroke-dashoffset: 0;
  stroke: var(--ax-border-strong);
  stroke-linecap: round;
}
HalvorHaugan commented 1 week ago

@KenAJoh Yes, it doesn't happen if I remove stroke-linecap 😅 It doesn't happen on my personal computer though, so it's probably just something weird with my work computer 😅 I wonder what it could be though, because it happens in incognito as well as in Chrome Beta, Canary and Dev too 🙃