Closed xuanswe closed 2 weeks ago
@ybelMekk do you agree so that I can contribute a PR?
From my understanding, OAuth2TokenProvider
is created only in 2 places:
OAuth2TokenProviderDeserializer
Here, the purpose is to convert json string into OAuth2TokenProvider
object.
In this case, we only need static systemTime
, so not relevant to the change.
OAuth2Config
Here, it could be done programmatically, both static and dynamic systemTime
are possible.
@ybelMekk PR created :)
Hi, could you please review the PR?
Could u please run :formatKotlin
and then push the changes?
@ybelMekk Thanks for merging and releasing! :)
A global fixed
systemTime
is not enough to write tests in practice at all.I propose to change the current implementation
to the backward compatible implemenation like below
I am not sure if we need to adapt anywhere else (ex.
OAuth2TokenProviderDeserializer
) with this change or not.