search

navikt / nav-dekoratoren-moduler

Moduler til nav-dekoratoren
0 stars 0 forks source link

analyticsUserConfig #70

Open max-nav opened 1 year ago

max-nav commented 1 year ago

Legge til dokumentasjon for analyticsUserConfig

Gir muligheten til å kunne sette user properties i amplitude klienten https://github.com/navikt/nav-dekoratoren/pull/1452/files#diff-32eacec6359e05a3186f490966e907b1fbd0f432dafc29aca12c60c91de8b986.

Bakgrunn: https://github.com/orgs/navikt/projects/89/views/1?filterQuery=+-status%3A%22I+arbeid+hos+andre%22%2C%22Venter+p%C3%A5+tilbakemelding%22+user&pane=issue&itemId=20931765

Testing

Eks: Har testet lokalt ved å spinne opp en frontend app og sende inn parameteret.

Skjermbilde hvis relevant

image
anders-nom commented 1 year ago

Husk å oppdater selve typedefinisjonen også 🙂 https://github.com/navikt/nav-dekoratoren-moduler/blob/bd9e2f08b869a592a166bf47edd1a7d69fe277b8/src/common/common-types.ts#L36C5-L36C5

max-nav commented 1 year ago

Done 🙌

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication