Adding VFB bridging registrations for missing VNC templates

navis-org / navis-flybrains

Transforms for navis that enable mapping between different Drosophila template brains.

GNU General Public License v3.0

7 stars 2 forks source link

Adding VFB bridging registrations for missing VNC templates #6

Closed Robbie1977 closed 2 years ago

Robbie1977 commented 2 years ago

@schlegelp let me know if any template names need changing to match your existing names

schlegelp commented 2 years ago

Nice PR! You can see the VNC templates in the bridging graph:

For consistency it'd be great if the unisex Janelia 2018 template was called JRC2018VNCU. Other than that, I'm happy to go with whatever is the established name. If there is wriggle room, I've tried sticking to these rules of thumb:

all capital letters for the name (that way we can add suffixes such as raw, um, nm, etc)
no separators (i.e. no dash or underscore)

A couple things would be nice to add to this PR:

Mention download_vfb_transforms in README
Minimal template brains (see templates.py and templates_meta.json) for any new brain space (ideally with mesh if available)

Once this is merged, I will update the bridging graph and bump the version.

schlegelp commented 2 years ago

Also looking at VirtualFlyBrain/VfbBridgingRegistrations I see that some transforms use a dash (-) instead of underscore (_) as separator in the folder name. Since flybrains is determining source and target via .split('_') these will likely fail to be parsed correctly.

schlegelp commented 2 years ago

Further to the above comment re how source and target are parsed: Greg has used {source}_{target} with respect to the forward transform as names.

Robbie1977 commented 2 years ago

@schlegelp I'm assuming you mean JRCVNC2018U (as per image) rather than JRC2018VNCU (as per comment)?

schlegelp commented 2 years ago

Ah yes, sorry.

Robbie1977 commented 2 years ago

@schlegelp I think I've added everything we have for now - missing a few meshes and you might want to redo the meshes as they are ImageJ marching cube ones so a lot larger than they probably could be.

Robbie1977 commented 2 years ago

@schlegelp I didn't update the alignment graph as don't have the same software so probably best you edit the original version

schlegelp commented 2 years ago

No problem on both accounts! Looks good to me. If you're happy too, I will push the merge button?

schlegelp commented 2 years ago

Hi @Robbie1977. I just now noticed that this PR is still missing entries in templates_meta.json the template brains you added. Do you happen to have that ready and just forgot to commit?