search

navis-org / pymaid

Python library to interface with CATMAID servers. Fully interoperable with navis.
https://pymaid.readthedocs.io/en/latest/
GNU General Public License v3.0
23 stars 11 forks source link

Annotation graph fixes, logging normalisation #226

Closed clbarnes closed 1 year ago

clbarnes commented 1 year ago

A couple of fixes/ improvements to the annotation graph fetcher, and allows pymaid to respect the NAVIS_SKIP_LOG_SETUP environment variable.

The recommendation for loggers is to use logging.getLogger(__name__) so that users can see and control where logs are coming from. Pymaid now does this if NAVIS_SKIP... is set, but defaults to the current look otherwise. New uses of logging should use logger = config.get_logger(__name__) rather than logger = config.logger. I intend to upstream this pattern to navis too.

schlegelp commented 1 year ago

Looks good to me. Happy for you to go ahead and merge.