Drop python 3.7, 3.8 - Githubissues

navis-org / pymaid

Python library to interface with CATMAID servers. Fully interoperable with navis.

https://pymaid.readthedocs.io/en/latest/

GNU General Public License v3.0

23 stars 11 forks source link

Drop python 3.7, 3.8 #239

Closed clbarnes closed 8 months ago

clbarnes commented 10 months ago

3.8 is not deprecated according to PSF, but to numpy, which is a community standard among scientific packages.

clbarnes commented 8 months ago

The remaining test failures (locally at least) are

from navis' use of csgraph using u32 instead of u64 internally, which I guess isn't being hit in navis' tests?
from VFB's FAFB instance docker setup having a shared memory size limit which is being hit when fetching the tag table, see https://groups.google.com/g/vfb-suport/c/4yJWTKWr2fo

clbarnes commented 8 months ago

The sparse graph thing is very odd, it works fine in navis, the data types seem to be the same in pymaid. If you turn the sparse adjacency matrix into a dense one and back again it works fine as well.

clbarnes commented 8 months ago

The navis tests are not actually testing the no-igraph case, see https://github.com/navis-org/navis/issues/139